annotate .gitignore @ 1788:1fc0012b9c38

Fix handling of replies to global requests (#112) The current code assumes that all global requests want / need a reply. This isn't always true and the request itself indicates if it wants a reply or not. It causes a specific problem with [email protected] messages. These are sent by OpenSSH after authentication to inform the client of potential other host keys for the host. This can be used to add a new type of host key or to rotate host keys. The initial information message from the server is sent as a global request, but with want_reply set to false. This means that the server doesn't expect an answer to this message. Instead the client needs to send a prove request as a reply if it wants to receive proof of ownership for the host keys. The bug doesn't cause any current problems with due to how OpenSSH treats receiving the failure message. It instead treats it as a keepalive message and further ignores it. Arguably this is a protocol violation though of Dropbear and it is only accidental that it doesn't cause a problem with OpenSSH. The bug was found when adding host keys support to libssh, which is more strict protocol wise and treats the unexpected failure message an error, also see https://gitlab.com/libssh/libssh-mirror/-/merge_requests/145 for more information. The fix here is to honor the want_reply flag in the global request and to only send a reply if the other side expects a reply.
author Dirkjan Bussink <d.bussink@gmail.com>
date Thu, 10 Dec 2020 16:13:13 +0100
parents f52919ffd3b1
children f78e67527731
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1393
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
1 *~
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
2 *.o
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
3 *.a
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
4 *.da
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
5 *.bb
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
6 *.bbg
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
7 *.prof
1653
76189c9ffea2 External Public-Key Authentication API (#72)
fabriziobertocci <fabriziobertocci@gmail.com>
parents: 1540
diff changeset
8 .*.swp
1393
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
9 /autom4te.cache
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
10 /config.log
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
11 /config.status
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
12 /dbclient
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
13 /dropbear
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
14 /dropbearconvert
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
15 /dropbearkey
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
16 /dropbearmulti
1655
f52919ffd3b1 update ltm to 1.1.0 and enable FIPS 186.4 compliant key-generation (#79)
Steffen Jaeckel <s_jaeckel@gmx.de>
parents: 1653
diff changeset
17 /fuzzcorpus
f52919ffd3b1 update ltm to 1.1.0 and enable FIPS 186.4 compliant key-generation (#79)
Steffen Jaeckel <s_jaeckel@gmx.de>
parents: 1653
diff changeset
18 /fuzzer-*
f52919ffd3b1 update ltm to 1.1.0 and enable FIPS 186.4 compliant key-generation (#79)
Steffen Jaeckel <s_jaeckel@gmx.de>
parents: 1653
diff changeset
19 /fuzzer-*.options
1393
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
20 /scp
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
21 /scp-progress
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
22 Makefile
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
23 config.h
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
24 config.h.in
ab4a3f783bfd Add .gitignore file
Ben Gardner <bgardner@wabtec.com>
parents:
diff changeset
25 configure
1540
03a42f41cf2c ignore default_options_guard.h
Matt Johnston <matt@ucc.asn.au>
parents: 1393
diff changeset
26 default_options_guard.h
1653
76189c9ffea2 External Public-Key Authentication API (#72)
fabriziobertocci <fabriziobertocci@gmail.com>
parents: 1540
diff changeset
27 tags