Mercurial > dropbear
annotate libtommath/bn_mp_get_long.c @ 1631:292f79307600
fix some gcc warnings (#73)
* tweak string size
fix gcc8 warnings
```
svr-agentfwd.c: In function 'bindagent':
svr-agentfwd.c:254:53: warning: '%s' directive output may be truncated writing up to 107 bytes into a region of size between 0 and 107 [-Wformat-truncation=]
snprintf(addr.sun_path, sizeof(addr.sun_path), "%s/%s", path, sockfile);
^~ ~~~~~~~~
svr-agentfwd.c:254:2: note: 'snprintf' output between 2 and 216 bytes into a destination of size 108
snprintf(addr.sun_path, sizeof(addr.sun_path), "%s/%s", path, sockfile);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
* cleanup signed/unsigned comparison
fix gcc8 warnings
```
scp.c: In function 'do_local_cmd':
scp.c:132:17: warning: comparison of integer expressions of different signedness: 'u_int' {aka 'unsigned int'} and 'int' [-Wsign-compare]
for (i = 0; i < a->num; i++)
^
scpmisc.c: In function 'addargs':
scpmisc.c:161:25: warning: comparison of integer expressions of different signedness: 'int' and 'u_int' {aka 'unsigned int'} [-Wsign-compare]
} else if (args->num+2 >= nalloc)
^~
scpmisc.c: In function 'replacearg':
scpmisc.c:183:12: warning: comparison of integer expressions of different signedness: 'u_int' {aka 'unsigned int'} and 'int' [-Wsign-compare]
if (which >= args->num)
^~
scpmisc.c: In function 'freeargs':
scpmisc.c:196:17: warning: comparison of integer expressions of different signedness: 'u_int' {aka 'unsigned int'} and 'int' [-Wsign-compare]
for (i = 0; i < args->num; i++)
^
```
see https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/misc.h.diff?r1=1.16&r2=1.17
| author | François Perrad <francois.perrad@gadz.org> |
|---|---|
| date | Wed, 20 Mar 2019 15:25:15 +0100 |
| parents | 60fc6476e044 |
| children | f52919ffd3b1 |
| rev | line source |
|---|---|
| 1436 | 1 #include <tommath_private.h> |
| 2 #ifdef BN_MP_GET_LONG_C | |
| 3 /* LibTomMath, multiple-precision integer library -- Tom St Denis | |
| 4 * | |
| 5 * LibTomMath is a library that provides multiple-precision | |
| 6 * integer arithmetic as well as number theoretic functionality. | |
| 7 * | |
| 8 * The library was designed directly after the MPI library by | |
| 9 * Michael Fromberger but has been written from scratch with | |
| 10 * additional optimizations in place. | |
| 11 * | |
| 12 * The library is free for all purposes without any express | |
| 13 * guarantee it works. | |
| 14 * | |
| 15 * Tom St Denis, [email protected], http://libtom.org | |
| 16 */ | |
| 17 | |
| 18 /* get the lower unsigned long of an mp_int, platform dependent */ | |
| 19 unsigned long mp_get_long(mp_int * a) | |
| 20 { | |
| 21 int i; | |
| 22 unsigned long res; | |
| 23 | |
| 24 if (a->used == 0) { | |
| 25 return 0; | |
| 26 } | |
| 27 | |
| 28 /* get number of digits of the lsb we have to read */ | |
| 29 i = MIN(a->used,(int)(((sizeof(unsigned long) * CHAR_BIT) + DIGIT_BIT - 1) / DIGIT_BIT)) - 1; | |
| 30 | |
| 31 /* get most significant digit of result */ | |
| 32 res = DIGIT(a,i); | |
| 33 | |
| 34 #if (ULONG_MAX != 0xffffffffuL) || (DIGIT_BIT < 32) | |
| 35 while (--i >= 0) { | |
| 36 res = (res << DIGIT_BIT) | DIGIT(a,i); | |
| 37 } | |
| 38 #endif | |
| 39 return res; | |
| 40 } | |
| 41 #endif |