dropbear: cli-kex.c annotate

annotate cli-kex.c @ 783:34e69908b3f7

Use '#' for host#port separator, document it. This fixes scp in multihop

author	Matt Johnston <matt@ucc.asn.au>
date	Wed, 17 Apr 2013 22:48:43 +0800
parents	2f1c199b6e4b
children	7dcb46da72d9

rev	line source
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	1 /*
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	2 * Dropbear - a SSH2 server
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	3 *
74 e3adf4cf5465 License boilerplate etc, add Mihnea as an author to some of the files Matt Johnston <matt@ucc.asn.au> parents: 59 diff changeset	4 * Copyright (c) 2002-2004 Matt Johnston
e3adf4cf5465 License boilerplate etc, add Mihnea as an author to some of the files Matt Johnston <matt@ucc.asn.au> parents: 59 diff changeset	5 * Copyright (c) 2004 by Mihnea Stoenescu
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	6 * All rights reserved.
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	7 *
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	8 * Permission is hereby granted, free of charge, to any person obtaining a copy
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	9 * of this software and associated documentation files (the "Software"), to deal
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	10 * in the Software without restriction, including without limitation the rights
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	11 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	12 * copies of the Software, and to permit persons to whom the Software is
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	13 * furnished to do so, subject to the following conditions:
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	14 *
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	15 * The above copyright notice and this permission notice shall be included in
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	16 * all copies or substantial portions of the Software.
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	17 *
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	18 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	19 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	20 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	21 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	22 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	23 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	24 * SOFTWARE. */
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	25
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	26 #include "includes.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	27 #include "session.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	28 #include "dbutil.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	29 #include "algo.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	30 #include "buffer.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	31 #include "session.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	32 #include "kex.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	33 #include "ssh.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	34 #include "packet.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	35 #include "bignum.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	36 #include "random.h"
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	37 #include "runopts.h"
33 f789045062e6 Progressing client support Matt Johnston <matt@ucc.asn.au> parents: 26 diff changeset	38 #include "signkey.h"
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	39
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	40
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	41 static void checkhostkey(unsigned char* keyblob, unsigned int keybloblen);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	42 #define MAX_KNOWNHOSTS_LINE 4500
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	43
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	44 void send_msg_kexdh_init() {
739 d44325108d0e first_kex_packet_follows working, needs tidying Matt Johnston <matt@ucc.asn.au> parents: 723 diff changeset	45 TRACE(("send_msg_kexdh_init()"))
745 15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	46 if ((cli_ses.dh_e && cli_ses.dh_x
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	47 && cli_ses.dh_val_algo == ses.newkeys->algo_kex)) {
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	48 TRACE(("reusing existing dh_e from first_kex_packet_follows"))
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	49 } else {
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	50 if (!cli_ses.dh_e \|\| !cli_ses.dh_e) {
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	51 cli_ses.dh_e = (mp_int*)m_malloc(sizeof(mp_int));
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	52 cli_ses.dh_x = (mp_int*)m_malloc(sizeof(mp_int));
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	53 m_mp_init_multi(cli_ses.dh_e, cli_ses.dh_x, NULL);
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	54 }
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	55
745 15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	56 gen_kexdh_vals(cli_ses.dh_e, cli_ses.dh_x);
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	57 cli_ses.dh_val_algo = ses.newkeys->algo_kex;
15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	58 }
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	59
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	60 CHECKCLEARTOWRITE();
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	61 buf_putbyte(ses.writepayload, SSH_MSG_KEXDH_INIT);
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	62 buf_putmpint(ses.writepayload, cli_ses.dh_e);
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	63 encrypt_packet();
775 2f1c199b6e4b requirenext fixup for firstkexfollows Matt Johnston <matt@ucc.asn.au> parents: 773 diff changeset	64 ses.requirenext[0] = SSH_MSG_KEXDH_REPLY;
2f1c199b6e4b requirenext fixup for firstkexfollows Matt Johnston <matt@ucc.asn.au> parents: 773 diff changeset	65 ses.requirenext[1] = SSH_MSG_KEXINIT;
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	66 }
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	67
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	68 /* Handle a diffie-hellman key exchange reply. */
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	69 void recv_msg_kexdh_reply() {
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	70
84 29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	71 DEF_MP_INT(dh_f);
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	72 sign_key *hostkey = NULL;
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	73 unsigned int type, keybloblen;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	74 unsigned char* keyblob = NULL;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	75
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	76
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	77 TRACE(("enter recv_msg_kexdh_reply"))
84 29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	78
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	79 if (cli_ses.kex_state != KEXDH_INIT_SENT) {
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	80 dropbear_exit("Received out-of-order kexdhreply");
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	81 }
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	82 m_mp_init(&dh_f);
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	83 type = ses.newkeys->algo_hostkey;
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	84 TRACE(("type is %d", type))
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	85
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	86 hostkey = new_sign_key();
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	87 keybloblen = buf_getint(ses.payload);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	88
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	89 keyblob = buf_getptr(ses.payload, keybloblen);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	90 if (!ses.kexstate.donefirstkex) {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	91 /* Only makes sense the first time */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	92 checkhostkey(keyblob, keybloblen);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	93 }
34 e2a1eaa19f22 Client mostly works up to password auth Matt Johnston <matt@ucc.asn.au> parents: 33 diff changeset	94
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	95 if (buf_get_pub_key(ses.payload, hostkey, &type) != DROPBEAR_SUCCESS) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	96 TRACE(("failed getting pubkey"))
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	97 dropbear_exit("Bad KEX packet");
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	98 }
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	99
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	100 if (buf_getmpint(ses.payload, &dh_f) != DROPBEAR_SUCCESS) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	101 TRACE(("failed getting mpint"))
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	102 dropbear_exit("Bad KEX packet");
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	103 }
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	104
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	105 kexdh_comb_key(cli_ses.dh_e, cli_ses.dh_x, &dh_f, hostkey);
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	106 mp_clear(&dh_f);
84 29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	107 mp_clear_multi(cli_ses.dh_e, cli_ses.dh_x, NULL);
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	108 m_free(cli_ses.dh_e);
29a5c7c62350 default initialisers for mp_ints Matt Johnston <matt@ucc.asn.au> parents: 80 diff changeset	109 m_free(cli_ses.dh_x);
745 15999b098cc9 Don't usually need to recalculate dh_e for the repeated kexdh_init packet Matt Johnston <matt@ucc.asn.au> parents: 743 diff changeset	110 cli_ses.dh_val_algo = DROPBEAR_KEX_NONE;
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	111
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	112 if (buf_verify(ses.payload, hostkey, ses.hash, SHA1_HASH_SIZE)
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	113 != DROPBEAR_SUCCESS) {
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	114 dropbear_exit("Bad hostkey signature");
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	115 }
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	116
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	117 sign_key_free(hostkey);
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	118 hostkey = NULL;
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	119
0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	120 send_msg_newkeys();
775 2f1c199b6e4b requirenext fixup for firstkexfollows Matt Johnston <matt@ucc.asn.au> parents: 773 diff changeset	121 ses.requirenext[0] = SSH_MSG_NEWKEYS;
2f1c199b6e4b requirenext fixup for firstkexfollows Matt Johnston <matt@ucc.asn.au> parents: 773 diff changeset	122 ses.requirenext[1] = 0;
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	123 TRACE(("leave recv_msg_kexdh_init"))
26 0969767bca0d snapshot of stuff Matt Johnston <matt@ucc.asn.au> parents: diff changeset	124 }
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	125
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	126 static void ask_to_confirm(unsigned char* keyblob, unsigned int keybloblen) {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	127
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	128 char* fp = NULL;
170 a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	129 FILE *tty = NULL;
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	130 char response = 'z';
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	131
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	132 fp = sign_key_fingerprint(keyblob, keybloblen);
418 ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	133 if (cli_opts.always_accept_key) {
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	134 fprintf(stderr, "\nHost '%s' key accepted unconditionally.\n(fingerprint %s)\n",
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	135 cli_opts.remotehost,
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	136 fp);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	137 m_free(fp);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	138 return;
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	139 }
440 91939c8c2572 Remove a newline from the kex prompt question, from FreeWRT Matt Johnston <matt@ucc.asn.au> parents: 436 diff changeset	140 fprintf(stderr, "\nHost '%s' is not in the trusted hosts file.\n(fingerprint %s)\nDo you want to continue connecting? (y/n) ",
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	141 cli_opts.remotehost,
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	142 fp);
340 454a34b2dfd1 Fixes from Erik Hovland: Matt Johnston <matt@ucc.asn.au> parents: 322 diff changeset	143 m_free(fp);
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	144
170 a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	145 tty = fopen(_PATH_TTY, "r");
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	146 if (tty) {
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	147 response = getc(tty);
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	148 fclose(tty);
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	149 } else {
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	150 response = getc(stdin);
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	151 }
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	152
a62cb364f615 Read "y/n" response for fingerprints from /dev/tty directly so that dbclient Matt Johnston <matt@ucc.asn.au> parents: 165 diff changeset	153 if (response == 'y') {
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	154 return;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	155 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	156
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	157 dropbear_exit("Didn't validate host key");
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	158 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	159
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	160 static FILE* open_known_hosts_file(int * readonly)
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	161 {
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	162 FILE * hostsfile = NULL;
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	163 char * filename = NULL;
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	164 char * homedir = NULL;
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	165
322 84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	166 homedir = getenv("HOME");
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	167
322 84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	168 if (!homedir) {
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	169 struct passwd * pw = NULL;
322 84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	170 pw = getpwuid(getuid());
84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	171 if (pw) {
84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	172 homedir = pw->pw_dir;
84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	173 }
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	174 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	175
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	176 if (homedir) {
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	177 unsigned int len;
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	178 len = strlen(homedir);
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	179 filename = m_malloc(len + 18); /* "/.ssh/known_hosts" and null-terminator*/
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	180
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	181 snprintf(filename, len+18, "%s/.ssh", homedir);
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	182 /* Check that ~/.ssh exists - easiest way is just to mkdir */
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	183 if (mkdir(filename, S_IRWXU) != 0) {
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	184 if (errno != EEXIST) {
322 84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	185 dropbear_log(LOG_INFO, "Warning: failed creating %s/.ssh: %s",
84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	186 homedir, strerror(errno));
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	187 TRACE(("mkdir didn't work: %s", strerror(errno)))
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	188 goto out;
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	189 }
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	190 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	191
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	192 snprintf(filename, len+18, "%s/.ssh/known_hosts", homedir);
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	193 hostsfile = fopen(filename, "a+");
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	194
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	195 if (hostsfile != NULL) {
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	196 *readonly = 0;
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	197 fseek(hostsfile, 0, SEEK_SET);
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	198 } else {
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	199 /* We mightn't have been able to open it if it was read-only */
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	200 if (errno == EACCES \|\| errno == EROFS) {
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	201 TRACE(("trying readonly: %s", strerror(errno)))
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	202 *readonly = 1;
318 9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	203 hostsfile = fopen(filename, "r");
9916350d7d8b don't fail fatally if the client can't get homedir from getpwuid(), fallback Matt Johnston <matt@ucc.asn.au> parents: 170 diff changeset	204 }
106 e13f8a712a1c Fix if the first write fails Matt Johnston <matt@ucc.asn.au> parents: 84 diff changeset	205 }
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	206 }
bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	207
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	208 if (hostsfile == NULL) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	209 TRACE(("hostsfile didn't open: %s", strerror(errno)))
322 84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	210 dropbear_log(LOG_WARNING, "Failed to open %s/.ssh/known_hosts",
84aa4e60bd3c Look at HOME before /etc/passwd when looking for ~/.ssh/known_hosts Matt Johnston <matt@ucc.asn.au> parents: 318 diff changeset	211 homedir);
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	212 goto out;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	213 }
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	214
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	215 out:
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	216 m_free(filename);
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	217 return hostsfile;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	218 }
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	219
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	220 static void checkhostkey(unsigned char* keyblob, unsigned int keybloblen) {
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	221
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	222 FILE *hostsfile = NULL;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	223 int readonly = 0;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	224 unsigned int hostlen, algolen;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	225 unsigned long len;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	226 const char *algoname = NULL;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	227 char * fingerprint = NULL;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	228 buffer * line = NULL;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	229 int ret;
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	230
772 7fc0aeada79c -y -y to disable hostkey checking Matt Johnston <matt@ucc.asn.au> parents: 568 diff changeset	231 if (cli_opts.no_hostkey_check) {
7fc0aeada79c -y -y to disable hostkey checking Matt Johnston <matt@ucc.asn.au> parents: 568 diff changeset	232 fprintf(stderr, "Caution, skipping hostkey check for %s\n", cli_opts.remotehost);
7fc0aeada79c -y -y to disable hostkey checking Matt Johnston <matt@ucc.asn.au> parents: 568 diff changeset	233 return;
7fc0aeada79c -y -y to disable hostkey checking Matt Johnston <matt@ucc.asn.au> parents: 568 diff changeset	234 }
7fc0aeada79c -y -y to disable hostkey checking Matt Johnston <matt@ucc.asn.au> parents: 568 diff changeset	235
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	236 hostsfile = open_known_hosts_file(&readonly);
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	237 if (!hostsfile) {
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	238 ask_to_confirm(keyblob, keybloblen);
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	239 /* ask_to_confirm will exit upon failure */
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	240 return;
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	241 }
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	242
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	243 line = buf_new(MAX_KNOWNHOSTS_LINE);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	244 hostlen = strlen(cli_opts.remotehost);
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	245 algoname = signkey_name_from_type(ses.newkeys->algo_hostkey, &algolen);
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	246
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	247 do {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	248 if (buf_getline(line, hostsfile) == DROPBEAR_FAILURE) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	249 TRACE(("failed reading line: prob EOF"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	250 break;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	251 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	252
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	253 /* The line is too short to be sensible */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	254 /* "30" is 'enough to hold ssh-dss plus the spaces, ie so we don't
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	255 * buf_getfoo() past the end and die horribly - the base64 parsing
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	256 * code is what tiptoes up to the end nicely */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	257 if (line->len < (hostlen+30) ) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	258 TRACE(("line is too short to be sensible"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	259 continue;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	260 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	261
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	262 /* Compare hostnames */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	263 if (strncmp(cli_opts.remotehost, buf_getptr(line, hostlen),
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	264 hostlen) != 0) {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	265 continue;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	266 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	267
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	268 buf_incrpos(line, hostlen);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	269 if (buf_getbyte(line) != ' ') {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	270 /* there wasn't a space after the hostname, something dodgy */
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	271 TRACE(("missing space afte matching hostname"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	272 continue;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	273 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	274
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	275 if (strncmp(buf_getptr(line, algolen), algoname, algolen) != 0) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	276 TRACE(("algo doesn't match"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	277 continue;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	278 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	279
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	280 buf_incrpos(line, algolen);
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	281 if (buf_getbyte(line) != ' ') {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	282 TRACE(("missing space after algo"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	283 continue;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	284 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	285
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	286 /* Now we're at the interesting hostkey */
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	287 ret = cmp_base64_key(keyblob, keybloblen, algoname, algolen,
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	288 line, &fingerprint);
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	289
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	290 if (ret == DROPBEAR_SUCCESS) {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	291 /* Good matching key */
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	292 TRACE(("good matching key"))
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	293 goto out;
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	294 }
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	295
436 7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	296 /* The keys didn't match. eep. Note that we're "leaking"
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	297 the fingerprint strings here, but we're exiting anyway */
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	298 dropbear_exit("\n\nHost key mismatch for %s !\n"
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	299 "Fingerprint is %s\n"
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	300 "Expected %s\n"
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	301 "If you know that the host key is correct you can\nremove the bad entry from ~/.ssh/known_hosts",
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	302 cli_opts.remotehost,
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	303 sign_key_fingerprint(keyblob, keybloblen),
7282370416a0 Improve known_hosts checking. Matt Johnston <matt@ucc.asn.au> parents: 418 diff changeset	304 fingerprint ? fingerprint : "UNKNOWN");
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	305 } while (1); /* keep going 'til something happens */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	306
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	307 /* Key doesn't exist yet */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	308 ask_to_confirm(keyblob, keybloblen);
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	309
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	310 /* If we get here, they said yes */
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	311
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	312 if (readonly) {
165 0cfba3034be5 Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place Matt Johnston <matt@ucc.asn.au> parents: 106 diff changeset	313 TRACE(("readonly"))
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	314 goto out;
bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	315 }
bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	316
418 ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	317 if (!cli_opts.always_accept_key) {
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	318 /* put the new entry in the file */
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	319 fseek(hostsfile, 0, SEEK_END); /* In case it wasn't opened append */
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	320 buf_setpos(line, 0);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	321 buf_setlen(line, 0);
568 005530560594 Rearrange getaddrstring() etc Matt Johnston <matt@ucc.asn.au> parents: 544 diff changeset	322 buf_putbytes(line, cli_opts.remotehost, hostlen);
418 ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	323 buf_putbyte(line, ' ');
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	324 buf_putbytes(line, algoname, algolen);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	325 buf_putbyte(line, ' ');
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	326 len = line->size - line->pos;
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	327 /* The only failure with base64 is buffer_overflow, but buf_getwriteptr
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	328 * will die horribly in the case anyway */
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	329 base64_encode(keyblob, keybloblen, buf_getwriteptr(line, len), &len);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	330 buf_incrwritepos(line, len);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	331 buf_putbyte(line, '\n');
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	332 buf_setpos(line, 0);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	333 fwrite(buf_getptr(line, line->len), line->len, 1, hostsfile);
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	334 /* We ignore errors, since there's not much we can do about them */
ab57ba0cb667 Add '-y' option to dbclient to accept the host key without checking Matt Johnston <matt@ucc.asn.au> parents: 340 diff changeset	335 }
59 bdc97a5719f4 add new entries to known_hosts Matt Johnston <matt@ucc.asn.au> parents: 51 diff changeset	336
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	337 out:
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	338 if (hostsfile != NULL) {
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	339 fclose(hostsfile);
095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	340 }
79 5a55bd66707f - don't crash when trying to add to known_hosts if it doesn't exist Matt Johnston <matt@ucc.asn.au> parents: 74 diff changeset	341 if (line != NULL) {
5a55bd66707f - don't crash when trying to add to known_hosts if it doesn't exist Matt Johnston <matt@ucc.asn.au> parents: 74 diff changeset	342 buf_free(line);
5a55bd66707f - don't crash when trying to add to known_hosts if it doesn't exist Matt Johnston <matt@ucc.asn.au> parents: 74 diff changeset	343 }
544 9e51707cd6f2 - Make -i and -W pass through multihop arguments Matt Johnston <matt@ucc.asn.au> parents: 440 diff changeset	344 m_free(fingerprint);
51 095d689fed16 - Hostkey checking is mostly there, just aren't appending yet. Matt Johnston <matt@ucc.asn.au> parents: 34 diff changeset	345 }

Mercurial > dropbear

annotate cli-kex.c @ 783:34e69908b3f7