Mercurial > dropbear
comparison svr-chansession.c @ 1930:299f4f19ba19
Add /usr/sbin and /sbin to default root PATH
When dropbear is used in a very restricted environment (such as in a
initrd), the default user shell is often also very restricted
and doesn't take care of setting the PATH so the user ends up
with the PATH set by dropbear. Unfortunately, dropbear always
sets "/usr/bin:/bin" as default PATH even for the root user
which should have /usr/sbin and /sbin too.
For a concrete instance of this problem, see the "Remote Unlocking"
section in this tutorial: https://paxswill.com/blog/2013/11/04/encrypted-raspberry-pi/
It speaks of a bug in the initramfs script because it's written "blkid"
instead of "/sbin/blkid"... this is just because the scripts from the
initramfs do not expect to have a PATH without the sbin directories and
because dropbear is not setting the PATH appropriately for the root user.
I'm thus suggesting to use the attached patch to fix this misbehaviour (I
did not test it, but it's easy enough). It might seem anecdotic but
multiple Kali users have been bitten by this.
From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903403
| author | Raphael Hertzog <hertzog@debian.org> |
|---|---|
| date | Mon, 09 Jul 2018 16:27:53 +0200 |
| parents | ffa0f666fde2 |
| children |
comparison
equal
deleted
inserted
replaced
| 1929:315dbcef7293 | 1930:299f4f19ba19 |
|---|---|
| 1010 /* set env vars */ | 1010 /* set env vars */ |
| 1011 addnewvar("USER", ses.authstate.pw_name); | 1011 addnewvar("USER", ses.authstate.pw_name); |
| 1012 addnewvar("LOGNAME", ses.authstate.pw_name); | 1012 addnewvar("LOGNAME", ses.authstate.pw_name); |
| 1013 addnewvar("HOME", ses.authstate.pw_dir); | 1013 addnewvar("HOME", ses.authstate.pw_dir); |
| 1014 addnewvar("SHELL", get_user_shell()); | 1014 addnewvar("SHELL", get_user_shell()); |
| 1015 addnewvar("PATH", DEFAULT_PATH); | 1015 if (getuid() == 0) { |
| 1016 addnewvar("PATH", DEFAULT_ROOT_PATH); | |
| 1017 } else { | |
| 1018 addnewvar("PATH", DEFAULT_PATH); | |
| 1019 } | |
| 1016 if (cp != NULL) { | 1020 if (cp != NULL) { |
| 1017 addnewvar("LANG", cp); | 1021 addnewvar("LANG", cp); |
| 1018 m_free(cp); | 1022 m_free(cp); |
| 1019 } | 1023 } |
| 1020 if (chansess->term != NULL) { | 1024 if (chansess->term != NULL) { |