diff fuzz/fuzz-common.c @ 1802:19b28d2fbe30

fuzz: handle errors from wrapfd_new_dummy()
author Matt Johnston <matt@ucc.asn.au>
date Sat, 06 Mar 2021 22:58:57 +0800
parents 4983a6bc1f51
children
line wrap: on
line diff
--- a/fuzz/fuzz-common.c	Fri Mar 05 22:51:11 2021 +0800
+++ b/fuzz/fuzz-common.c	Sat Mar 06 22:58:57 2021 +0800
@@ -230,11 +230,20 @@
     if (ret_errfd) {
         *ret_errfd = wrapfd_new_dummy();
     }
-    *ret_pid = 999;
-    return DROPBEAR_SUCCESS;
+    if (*ret_writefd == -1 || *ret_readfd == -1 || (ret_errfd && *ret_errfd == -1)) {
+        m_close(*ret_writefd);
+        m_close(*ret_readfd);
+        if (ret_errfd) {
+            m_close(*ret_errfd);
+        }
+        return DROPBEAR_FAILURE;
+    } else {
+        *ret_pid = 999;
+        return DROPBEAR_SUCCESS;
+
+    }
 }
 
-
 /* Fake dropbear_listen, always returns failure for now.
 TODO make it sometimes return success with wrapfd_new_dummy() sockets.
 Making the listeners fake a new incoming connection will be harder. */