diff common-session.c @ 275:7f9adaf85fca

Exit with a message if the ssh protocol version is incompatible
author Matt Johnston <matt@ucc.asn.au>
date Sat, 04 Mar 2006 08:22:16 +0000
parents 3311f4aa52cb
children bf29e6659fb9
line wrap: on
line diff
--- a/common-session.c	Tue Feb 28 04:04:27 2006 +0000
+++ b/common-session.c	Sat Mar 04 08:22:16 2006 +0000
@@ -232,10 +232,8 @@
 		dropbear_exit("Error writing ident string");
 	}
 
-	/* We allow up to 9 lines before the actual version string, to
-	 * account for wrappers/cruft etc. According to the spec only the client
-	 * needs to handle this, but no harm in letting the server handle it too */
-	for (i = 0; i < 10; i++) {
+    /* If they send more than 50 lines, something is wrong */
+	for (i = 0; i < 50; i++) {
 		len = ident_readln(ses.sock, linebuf, sizeof(linebuf));
 
 		if (len < 0 && errno != EINTR) {
@@ -259,6 +257,12 @@
 		memcpy(ses.remoteident, linebuf, len);
 	}
 
+    /* Shall assume that 2.x will be backwards compatible. */
+    if (strncmp(ses.remoteident, "SSH-2.", 6) != 0
+            && strncmp(ses.remoteident, "SSH-1.99-", 9) != 0) {
+        dropbear_exit("Incompatible remote version '%s'", ses.remoteident);
+    }
+
 	TRACE(("remoteident: %s", ses.remoteident))
 
 }