Mercurial > dropbear
diff dss.c @ 1418:92717c0fec39
check p and q lengths
author | Matt Johnston <matt@ucc.asn.au> |
---|---|
date | Fri, 16 Jun 2017 22:35:18 +0800 |
parents | a54b22f4058d |
children | 69862e8cc405 7aebe7da3a35 |
line wrap: on
line diff
--- a/dss.c Fri Jun 23 21:31:25 2017 +0800 +++ b/dss.c Fri Jun 16 22:35:18 2017 +0800 @@ -61,8 +61,15 @@ goto out; } - if (mp_count_bits(key->p) < MIN_DSS_KEYLEN) { - dropbear_log(LOG_WARNING, "DSS key too short"); + if (mp_count_bits(key->p) < DSS_P_BITS) { + dropbear_log(LOG_WARNING, "Bad DSS p"); + TRACE(("leave buf_get_dss_pub_key: short key")) + ret = DROPBEAR_FAILURE; + goto out; + } + + if (mp_count_bits(key->q) < DSS_Q_BITS) { + dropbear_log(LOG_WARNING, "Bad DSS q"); TRACE(("leave buf_get_dss_pub_key: short key")) ret = DROPBEAR_FAILURE; goto out;