Mercurial > dropbear
diff dbutil.c @ 357:9e2ad1023978
Handle failure reading a file (such as a key file)
author | Matt Johnston <matt@ucc.asn.au> |
---|---|
date | Sun, 20 Aug 2006 12:16:13 +0000 |
parents | e17f0333c21e |
children | e81d3bc1dc78 |
line wrap: on
line diff
--- a/dbutil.c Mon Aug 07 13:41:23 2006 +0000 +++ b/dbutil.c Sun Aug 20 12:16:13 2006 +0000 @@ -527,26 +527,36 @@ * Returns DROPBEAR_SUCCESS or DROPBEAR_FAILURE */ int buf_readfile(buffer* buf, const char* filename) { - int fd; + int fd = -1; int len; int maxlen; + ret = DROPBEAR_FAILURE; fd = open(filename, O_RDONLY); if (fd < 0) { - close(fd); - return DROPBEAR_FAILURE; + goto out; } do { maxlen = buf->size - buf->pos; - len = read(fd, buf_getwriteptr(buf, maxlen), - maxlen); + len = read(fd, buf_getwriteptr(buf, maxlen), maxlen); + if (len < 0) { + if (errno == EINTR || errno == EAGAIN) { + continue; + } + goto out; + } buf_incrwritepos(buf, len); } while (len < maxlen && len > 0); - close(fd); - return DROPBEAR_SUCCESS; + ret = DROPBEAR_SUCCESS; + +out: + if (fd >= 0) { + m_close(fd); + } + return ret; } /* get a line from the file into buffer in the style expected for an