Mercurial > dropbear
view libtomcrypt/coverity.sh @ 1930:299f4f19ba19
Add /usr/sbin and /sbin to default root PATH
When dropbear is used in a very restricted environment (such as in a
initrd), the default user shell is often also very restricted
and doesn't take care of setting the PATH so the user ends up
with the PATH set by dropbear. Unfortunately, dropbear always
sets "/usr/bin:/bin" as default PATH even for the root user
which should have /usr/sbin and /sbin too.
For a concrete instance of this problem, see the "Remote Unlocking"
section in this tutorial: https://paxswill.com/blog/2013/11/04/encrypted-raspberry-pi/
It speaks of a bug in the initramfs script because it's written "blkid"
instead of "/sbin/blkid"... this is just because the scripts from the
initramfs do not expect to have a PATH without the sbin directories and
because dropbear is not setting the PATH appropriately for the root user.
I'm thus suggesting to use the attached patch to fix this misbehaviour (I
did not test it, but it's easy enough). It might seem anecdotic but
multiple Kali users have been bitten by this.
From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903403
author | Raphael Hertzog <hertzog@debian.org> |
---|---|
date | Mon, 09 Jul 2018 16:27:53 +0200 |
parents | 6dba84798cd5 |
children |
line wrap: on
line source
#!/bin/bash if [ $# -lt 2 ] then echo "usage is: ${0##*/} <path to coverity scan> <extra compiler options>" echo "e.g. \"${0##*/} \"/usr/local/bin/coverity\" \"-DLTM_DESC -I/path/to/libtommath/\"\"" exit -1 fi PATH=$PATH:$1/bin make clean rm -r cov-int/ myCflags="" myCflags="$myCflags -O2 ${2}" myCflags="$myCflags -pipe -Werror -Wpointer-arith -Winit-self -Wextra -Wall -Wformat -Wformat-security" CFLAGS="$myCflags" cov-build --dir cov-int make -f makefile.unix $MAKE_OPTS IGNORE_SPEED=1 1>gcc_1.txt if [ $? -ne 0 ] then echo "make failed" exit -1 fi # zipup everything tar caf libtomcrypt.lzma cov-int mytoken=$(cat .coverity_token) mymail=$(cat .coverity_mail) myversion=$(git describe --dirty) curl -k --form project=libtomcrypt \ --form token=${mytoken} \ --form email=${mymail} \ --form file=@libtomcrypt.lzma \ --form version=\"${myversion}\" \ --form description="\"libtomcrypt version ${myversion}\"" \ https://scan.coverity.com/builds?project=libtom%2Flibtomcrypt