Mercurial > dropbear
view libtomcrypt/coverity.sh @ 1630:9579377b5f8b
use strlcpy & strlcat (#74)
* refactor checkpubkeyperms() with safe BSD functions
fix gcc8 warnings
```
svr-authpubkey.c: In function 'checkpubkeyperms':
svr-authpubkey.c:427:2: warning: 'strncat' specified bound 5 equals source length [-Wstringop-overflow=]
strncat(filename, "/.ssh", 5); /* strlen("/.ssh") == 5 */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svr-authpubkey.c:433:2: warning: 'strncat' specified bound 16 equals source length [-Wstringop-overflow=]
strncat(filename, "/authorized_keys", 16);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
see https://www.sudo.ws/todd/papers/strlcpy.html
* restore strlcpy in xstrdup
see original https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/xmalloc.c?rev=1.16
author | François Perrad <francois.perrad@gadz.org> |
---|---|
date | Wed, 20 Mar 2019 15:09:19 +0100 |
parents | 6dba84798cd5 |
children |
line wrap: on
line source
#!/bin/bash if [ $# -lt 2 ] then echo "usage is: ${0##*/} <path to coverity scan> <extra compiler options>" echo "e.g. \"${0##*/} \"/usr/local/bin/coverity\" \"-DLTM_DESC -I/path/to/libtommath/\"\"" exit -1 fi PATH=$PATH:$1/bin make clean rm -r cov-int/ myCflags="" myCflags="$myCflags -O2 ${2}" myCflags="$myCflags -pipe -Werror -Wpointer-arith -Winit-self -Wextra -Wall -Wformat -Wformat-security" CFLAGS="$myCflags" cov-build --dir cov-int make -f makefile.unix $MAKE_OPTS IGNORE_SPEED=1 1>gcc_1.txt if [ $? -ne 0 ] then echo "make failed" exit -1 fi # zipup everything tar caf libtomcrypt.lzma cov-int mytoken=$(cat .coverity_token) mymail=$(cat .coverity_mail) myversion=$(git describe --dirty) curl -k --form project=libtomcrypt \ --form token=${mytoken} \ --form email=${mymail} \ --form file=@libtomcrypt.lzma \ --form version=\"${myversion}\" \ --form description="\"libtomcrypt version ${myversion}\"" \ https://scan.coverity.com/builds?project=libtom%2Flibtomcrypt