Mercurial > dropbear
view libtomcrypt/src/math/radix_to_bin.c @ 1630:9579377b5f8b
use strlcpy & strlcat (#74)
* refactor checkpubkeyperms() with safe BSD functions
fix gcc8 warnings
```
svr-authpubkey.c: In function 'checkpubkeyperms':
svr-authpubkey.c:427:2: warning: 'strncat' specified bound 5 equals source length [-Wstringop-overflow=]
strncat(filename, "/.ssh", 5); /* strlen("/.ssh") == 5 */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svr-authpubkey.c:433:2: warning: 'strncat' specified bound 16 equals source length [-Wstringop-overflow=]
strncat(filename, "/authorized_keys", 16);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
see https://www.sudo.ws/todd/papers/strlcpy.html
* restore strlcpy in xstrdup
see original https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/xmalloc.c?rev=1.16
author | François Perrad <francois.perrad@gadz.org> |
---|---|
date | Wed, 20 Mar 2019 15:09:19 +0100 |
parents | 6dba84798cd5 |
children |
line wrap: on
line source
/* LibTomCrypt, modular cryptographic library -- Tom St Denis * * LibTomCrypt is a library that provides various cryptographic * algorithms in a highly modular and flexible manner. * * The library is free for all purposes without any express * guarantee it works. */ #include "tomcrypt.h" /** @file radix_to_bin.c Convert data from a specific radix to binary. Steffen Jaeckel */ /** Convert data from a specific radix to binary The default MPI descriptors #ltm_desc, #tfm_desc and #gmp_desc have the following restrictions on parameters: \p in - NUL-terminated char buffer \p radix - 2..64 @param in The input @param radix The radix of the input @param out The output buffer @param len [in/out] The length of the output buffer @return CRYPT_OK on success. */ int radix_to_bin(const void *in, int radix, void *out, unsigned long *len) { unsigned long l; void* mpi; int err; LTC_ARGCHK(in != NULL); LTC_ARGCHK(len != NULL); if ((err = mp_init(&mpi)) != CRYPT_OK) return err; if ((err = mp_read_radix(mpi, in, radix)) != CRYPT_OK) goto LBL_ERR; if ((l = mp_unsigned_bin_size(mpi)) > *len) { *len = l; err = CRYPT_BUFFER_OVERFLOW; goto LBL_ERR; } *len = l; if ((err = mp_to_unsigned_bin(mpi, out)) != CRYPT_OK) goto LBL_ERR; LBL_ERR: mp_clear(mpi); return err; } /* ref: $Format:%D$ */ /* git commit: $Format:%H$ */ /* commit time: $Format:%ai$ */