Mercurial > dropbear
view libtomcrypt/src/pk/asn1/der/generalizedtime/der_encode_generalizedtime.c @ 1630:9579377b5f8b
use strlcpy & strlcat (#74)
* refactor checkpubkeyperms() with safe BSD functions
fix gcc8 warnings
```
svr-authpubkey.c: In function 'checkpubkeyperms':
svr-authpubkey.c:427:2: warning: 'strncat' specified bound 5 equals source length [-Wstringop-overflow=]
strncat(filename, "/.ssh", 5); /* strlen("/.ssh") == 5 */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svr-authpubkey.c:433:2: warning: 'strncat' specified bound 16 equals source length [-Wstringop-overflow=]
strncat(filename, "/authorized_keys", 16);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
see https://www.sudo.ws/todd/papers/strlcpy.html
* restore strlcpy in xstrdup
see original https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/xmalloc.c?rev=1.16
author | François Perrad <francois.perrad@gadz.org> |
---|---|
date | Wed, 20 Mar 2019 15:09:19 +0100 |
parents | 6dba84798cd5 |
children |
line wrap: on
line source
/* LibTomCrypt, modular cryptographic library -- Tom St Denis * * LibTomCrypt is a library that provides various cryptographic * algorithms in a highly modular and flexible manner. * * The library is free for all purposes without any express * guarantee it works. */ #include "tomcrypt.h" /** @file der_encode_utctime.c ASN.1 DER, encode a GeneralizedTime, Steffen Jaeckel Based on der_encode_utctime.c */ #ifdef LTC_DER static const char * const baseten = "0123456789"; #define STORE_V(y) do {\ out[x++] = der_ia5_char_encode(baseten[(y/10) % 10]); \ out[x++] = der_ia5_char_encode(baseten[y % 10]); \ } while(0) #define STORE_V4(y) do {\ out[x++] = der_ia5_char_encode(baseten[(y/1000) % 10]); \ out[x++] = der_ia5_char_encode(baseten[(y/100) % 10]); \ out[x++] = der_ia5_char_encode(baseten[(y/10) % 10]); \ out[x++] = der_ia5_char_encode(baseten[y % 10]); \ } while(0) /** Encodes a Generalized time structure in DER format @param gtime The GeneralizedTime structure to encode @param out The destination of the DER encoding of the GeneralizedTime structure @param outlen [in/out] The length of the DER encoding @return CRYPT_OK if successful */ int der_encode_generalizedtime(ltc_generalizedtime *gtime, unsigned char *out, unsigned long *outlen) { unsigned long x, tmplen; int err; LTC_ARGCHK(gtime != NULL); LTC_ARGCHK(out != NULL); LTC_ARGCHK(outlen != NULL); if ((err = der_length_generalizedtime(gtime, &tmplen)) != CRYPT_OK) { return err; } if (tmplen > *outlen) { *outlen = tmplen; return CRYPT_BUFFER_OVERFLOW; } /* store header */ out[0] = 0x18; /* store values */ x = 2; STORE_V4(gtime->YYYY); STORE_V(gtime->MM); STORE_V(gtime->DD); STORE_V(gtime->hh); STORE_V(gtime->mm); STORE_V(gtime->ss); if (gtime->fs) { unsigned long divisor; unsigned fs = gtime->fs; unsigned len = 0; out[x++] = der_ia5_char_encode('.'); divisor = 1; do { fs /= 10; divisor *= 10; len++; } while(fs != 0); while (len-- > 1) { divisor /= 10; out[x++] = der_ia5_char_encode(baseten[(gtime->fs/divisor) % 10]); } out[x++] = der_ia5_char_encode(baseten[gtime->fs % 10]); } if (gtime->off_mm || gtime->off_hh) { out[x++] = der_ia5_char_encode(gtime->off_dir ? '-' : '+'); STORE_V(gtime->off_hh); STORE_V(gtime->off_mm); } else { out[x++] = der_ia5_char_encode('Z'); } /* store length */ out[1] = (unsigned char)(x - 2); /* all good let's return */ *outlen = x; return CRYPT_OK; } #endif /* ref: $Format:%D$ */ /* git commit: $Format:%H$ */ /* commit time: $Format:%ai$ */