Mercurial > dropbear
view list.c @ 1630:9579377b5f8b
use strlcpy & strlcat (#74)
* refactor checkpubkeyperms() with safe BSD functions
fix gcc8 warnings
```
svr-authpubkey.c: In function 'checkpubkeyperms':
svr-authpubkey.c:427:2: warning: 'strncat' specified bound 5 equals source length [-Wstringop-overflow=]
strncat(filename, "/.ssh", 5); /* strlen("/.ssh") == 5 */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svr-authpubkey.c:433:2: warning: 'strncat' specified bound 16 equals source length [-Wstringop-overflow=]
strncat(filename, "/authorized_keys", 16);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
see https://www.sudo.ws/todd/papers/strlcpy.html
* restore strlcpy in xstrdup
see original https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/xmalloc.c?rev=1.16
author | François Perrad <francois.perrad@gadz.org> |
---|---|
date | Wed, 20 Mar 2019 15:09:19 +0100 |
parents | d68d61e7056a |
children |
line wrap: on
line source
#include "includes.h" #include "dbutil.h" #include "list.h" void list_append(m_list *list, void *item) { m_list_elem *elem; elem = m_malloc(sizeof(*elem)); elem->item = item; elem->list = list; elem->next = NULL; if (!list->first) { list->first = elem; elem->prev = NULL; } else { elem->prev = list->last; list->last->next = elem; } list->last = elem; } m_list * list_new() { m_list *ret = m_malloc(sizeof(m_list)); ret->first = ret->last = NULL; return ret; } void * list_remove(m_list_elem *elem) { void *item = elem->item; m_list *list = elem->list; if (list->first == elem) { list->first = elem->next; } if (list->last == elem) { list->last = elem->prev; } if (elem->prev) { elem->prev->next = elem->next; } if (elem->next) { elem->next->prev = elem->prev; } m_free(elem); return item; }