# HG changeset patch # User Matt Johnston # Date 1093166639 0 # Node ID 0247fbd9379df9376ba24d8c3da027b70dcba078 # Parent 297167ef41bdac378ad2bd73ac7eae22bb0d5f03 Move the revert-to-non-blocking-stdin code to cli-session so it always gets hit. diff -r 297167ef41bd -r 0247fbd9379d cli-chansession.c --- a/cli-chansession.c Sun Aug 22 09:23:11 2004 +0000 +++ b/cli-chansession.c Sun Aug 22 09:23:59 2004 +0000 @@ -63,10 +63,6 @@ cli_tty_cleanup(); /* Restore tty modes etc */ - /* Set stdin back to non-blocking - busybox ash dies nastily - * if we don't revert the flags */ - fcntl(cli_ses.stdincopy, F_SETFL, cli_ses.stdinflags); - } static void start_channel_request(struct Channel *channel, @@ -317,13 +313,9 @@ static int cli_initchansess(struct Channel *channel) { - /* We store stdin's flags, so we can set them back on exit (otherwise - * busybox's ash isn't happy */ - cli_ses.stdincopy = dup(STDIN_FILENO); - cli_ses.stdinflags = fcntl(STDIN_FILENO, F_GETFL, 0); channel->infd = STDOUT_FILENO; - //channel->outfd = STDIN_FILENO; + channel->outfd = STDIN_FILENO; //channel->errfd = STDERR_FILENO; if (cli_opts.wantpty) { diff -r 297167ef41bd -r 0247fbd9379d cli-session.c --- a/cli-session.c Sun Aug 22 09:23:11 2004 +0000 +++ b/cli-session.c Sun Aug 22 09:23:59 2004 +0000 @@ -112,6 +112,11 @@ cli_ses.tty_raw_mode = 0; cli_ses.winchange = 0; + /* We store stdin's flags, so we can set them back on exit (otherwise + * busybox's ash isn't happy */ + cli_ses.stdincopy = dup(STDIN_FILENO); + cli_ses.stdinflags = fcntl(STDIN_FILENO, F_GETFL, 0); + /* Auth */ cli_ses.lastpubkey = NULL; cli_ses.lastauthtype = NULL; @@ -240,6 +245,12 @@ if (!sessinitdone) { return; } + + /* Set stdin back to non-blocking - busybox ash dies nastily + * if we don't revert the flags */ + TRACE(("close stdincopy = %d", cli_ses.stdincopy)); + //fcntl(cli_ses.stdincopy, F_SETFL, cli_ses.stdinflags); + cli_tty_cleanup(); }