# HG changeset patch # User Matt Johnston # Date 1336610317 -28800 # Node ID 03073a27abb343958b00b81d420993aa8da258de # Parent 6e0899b56ac4482a76e3dc51d02ca2d7e0d1883a - Add hmac-sha2-256 and hmac-sha2-512. Needs debugging, seems to be getting keyed incorrectly diff -r 6e0899b56ac4 -r 03073a27abb3 common-algo.c --- a/common-algo.c Wed May 09 22:52:58 2012 +0800 +++ b/common-algo.c Thu May 10 08:38:37 2012 +0800 @@ -106,6 +106,14 @@ static const struct dropbear_hash dropbear_sha1_96 = {&sha1_desc, 20, 12}; #endif +#ifdef DROPBEAR_SHA2_256_HMAC +static const struct dropbear_hash dropbear_sha2_256 = + {&sha256_desc, 32, 32}; +#endif +#ifdef DROPBEAR_SHA2_512_HMAC +static const struct dropbear_hash dropbear_sha2_512 = + {&sha512_desc, 64, 64}; +#endif #ifdef DROPBEAR_MD5_HMAC static const struct dropbear_hash dropbear_md5 = {&md5_desc, 16, 16}; @@ -156,6 +164,12 @@ }; algo_type sshhashes[] = { +#ifdef DROPBEAR_SHA2_256_HMAC +// {"hmac-sha2-256", 0, &dropbear_sha2_256, 1, NULL}, +#endif +#ifdef DROPBEAR_SHA2_512_HMAC +// {"hmac-sha2-512", 0, &dropbear_sha2_512, 1, NULL}, +#endif #ifdef DROPBEAR_SHA1_96_HMAC {"hmac-sha1-96", 0, &dropbear_sha1_96, 1, NULL}, #endif diff -r 6e0899b56ac4 -r 03073a27abb3 common-kex.c --- a/common-kex.c Wed May 09 22:52:58 2012 +0800 +++ b/common-kex.c Thu May 10 08:38:37 2012 +0800 @@ -248,26 +248,28 @@ * already initialised hash_state hs, which should already have processed * the dh_K and hash, since these are common. X is the letter 'A', 'B' etc. * out must have at least min(SHA1_HASH_SIZE, outlen) bytes allocated. - * The output will only be expanded once, as we are assured that - * outlen <= 2*SHA1_HASH_SIZE for all known hashes. * * See Section 7.2 of rfc4253 (ssh transport) for details */ static void hashkeys(unsigned char *out, int outlen, const hash_state * hs, const unsigned char X) { hash_state hs2; - unsigned char k2[SHA1_HASH_SIZE]; /* used to extending */ + int offset; memcpy(&hs2, hs, sizeof(hash_state)); sha1_process(&hs2, &X, 1); sha1_process(&hs2, ses.session_id, SHA1_HASH_SIZE); sha1_done(&hs2, out); - if (SHA1_HASH_SIZE < outlen) { + for (offset = SHA1_HASH_SIZE; + offset < outlen; + offset += SHA1_HASH_SIZE) + { /* need to extend */ + unsigned char k2[SHA1_HASH_SIZE]; memcpy(&hs2, hs, sizeof(hash_state)); - sha1_process(&hs2, out, SHA1_HASH_SIZE); + sha1_process(&hs2, out, offset); sha1_done(&hs2, k2); - memcpy(&out[SHA1_HASH_SIZE], k2, outlen - SHA1_HASH_SIZE); + memcpy(&out[offset], k2, MIN(outlen - offset, SHA1_HASH_SIZE)); } } diff -r 6e0899b56ac4 -r 03073a27abb3 libtomcrypt/src/headers/tomcrypt_custom.h --- a/libtomcrypt/src/headers/tomcrypt_custom.h Wed May 09 22:52:58 2012 +0800 +++ b/libtomcrypt/src/headers/tomcrypt_custom.h Thu May 10 08:38:37 2012 +0800 @@ -118,14 +118,18 @@ #define LTC_CTR_MODE #endif -#if defined(DROPBEAR_DSS) && defined(DSS_PROTOK) -#define SHA512 +#define SHA1 + +#ifdef DROPBEAR_MD5 +#define MD5 #endif -#define SHA1 +#ifdef DROPBEAR_SHA256 +#define SHA256 +#endif -#ifdef DROPBEAR_MD5_HMAC -#define MD5 +#ifdef DROPBEAR_SHA512 +#define SHA512 #endif #define LTC_HMAC diff -r 6e0899b56ac4 -r 03073a27abb3 options.h --- a/options.h Wed May 09 22:52:58 2012 +0800 +++ b/options.h Thu May 10 08:38:37 2012 +0800 @@ -112,6 +112,8 @@ #define DROPBEAR_SHA1_HMAC #define DROPBEAR_SHA1_96_HMAC +#define DROPBEAR_SHA2_256_HMAC +#define DROPBEAR_SHA2_512_HMAC #define DROPBEAR_MD5_HMAC /* Hostkey/public key algorithms - at least one required, these are used diff -r 6e0899b56ac4 -r 03073a27abb3 sysoptions.h --- a/sysoptions.h Wed May 09 22:52:58 2012 +0800 +++ b/sysoptions.h Thu May 10 08:38:37 2012 +0800 @@ -90,7 +90,13 @@ #define MAX_KEY_LEN 32 /* 256 bits for aes256 etc */ #define MAX_IV_LEN 20 /* must be same as max blocksize, and >= SHA1_HASH_SIZE */ +#if defined(DROPBEAR_SHA2_512_HMAC) +#define MAX_MAC_KEY 64 +#elif defined(DROPBEAR_SHA2_256_HMAC) +#define MAX_MAC_KEY 32 +#else #define MAX_MAC_KEY 20 +#endif #define MAX_NAME_LEN 64 /* maximum length of a protocol name, isn't explicitly specified for all protocols (just @@ -144,6 +150,19 @@ #define DROPBEAR_TWOFISH #endif +#ifdef DROPBEAR_MD5_HMAC +#define DROPBEAR_MD5 +#endif + +#ifdef DROPBEAR_SHA2_256_HMAC +#define DROPBEAR_SHA256 +#endif + +#if (defined(DROPBEAR_DSS) && defined(DSS_PROTOK)) \ + || defined(DROPBEAR_SHA2_512_HMAC) +#define DROPBEAR_SHA512 +#endif + #ifndef ENABLE_X11FWD #define DISABLE_X11FWD #endif