# HG changeset patch
# User Matt Johnston <matt@ucc.asn.au>
# Date 1152255610 0
# Node ID 31743c9bdf789b397e01ff472dbee23dad41c687
# Parent  1c7a072000e0f74369d837c9b44467039568d3dc
BUG: The strings 'name' and 'instruction' are always allocated
but are only freed if the length of the string is greater then
zero. They should always be freed.
FIX: take the m_free(<string>) out of the conditional

From Erik Hovland

diff -r 1c7a072000e0 -r 31743c9bdf78 cli-authinteract.c
--- a/cli-authinteract.c	Fri Jul 07 06:43:55 2006 +0000
+++ b/cli-authinteract.c	Fri Jul 07 07:00:10 2006 +0000
@@ -99,13 +99,14 @@
 	if (strlen(name) > 0) {
 		cleantext(name);
 		fprintf(stderr, "%s", name);
-		m_free(name);
 	}
+	m_free(name);
+
 	if (strlen(instruction) > 0) {
 		cleantext(instruction);
 		fprintf(stderr, "%s", instruction);
-		m_free(instruction);
 	}
+	m_free(instruction);
 
 	for (i = 0; i < num_prompts; i++) {
 		unsigned int response_len = 0;