# HG changeset patch # User Matt Johnston # Date 1498236427 -28800 # Node ID 69862e8cc405273606767c98800fb47859ad3f86 # Parent 4f17d75d027b56cc7196372208b938fa9f449af2# Parent f0e262a46d4e0d0596f219359b63c5af9d30fd02 merge from main diff -r 4f17d75d027b -r 69862e8cc405 configure.ac --- a/configure.ac Fri Jun 23 21:31:49 2017 +0800 +++ b/configure.ac Sat Jun 24 00:47:07 2017 +0800 @@ -19,6 +19,7 @@ fi AC_SUBST(LD) +# set compile flags prior to other tests if test -z "$OLDCFLAGS" && test "$GCC" = "yes"; then AC_MSG_NOTICE(No \$CFLAGS set... using "-Os -W -Wall" for GCC) CFLAGS="-Os -W -Wall -Wno-pointer-sign" @@ -29,12 +30,70 @@ CFLAGS="$CFLAGS -fno-strict-overflow" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], [AC_MSG_RESULT(yes)], - [ - AC_MSG_RESULT(no) - CFLAGS=$OLDCFLAGS - ] + [AC_MSG_RESULT(no); CFLAGS="$OLDCFLAGS" ] ) +hardenbuild=1 +AC_ARG_ENABLE(harden, + [ --disable-harden Don't set hardened build flags], + [ + if test "x$enableval" = "xno"; then + hardenbuild=0 + AC_MSG_NOTICE(Disabling hardened build flags) + fi + ], []) + +if test "$hardenbuild" -eq 1; then + AC_MSG_NOTICE(Checking for available hardened build flags:) + # pie + OLDCFLAGS="$CFLAGS" + TESTFLAGS="-fPIE" + CFLAGS="$CFLAGS $TESTFLAGS" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [AC_MSG_NOTICE([Not setting $TESTFLAGS]); CFLAGS="$OLDCFLAGS" ] + ) + OLDLDFLAGS="$LDFLAGS" + TESTFLAGS="-Wl,-pie" + LDFLAGS="$LDFLAGS $TESTFLAGS" + AC_LINK_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [AC_MSG_NOTICE([Not setting $TESTFLAGS]); LDFLAGS="$OLDLDFLAGS" ] + ) + # readonly elf relocation sections (relro) + OLDLDFLAGS="$LDFLAGS" + TESTFLAGS="-Wl,-z,now -Wl,-z,relro" + LDFLAGS="$LDFLAGS $TESTFLAGS" + AC_LINK_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [AC_MSG_NOTICE([Not setting $TESTFLAGS]); LDFLAGS="$OLDLDFLAGS" ] + ) + # stack protector. -strong is good but only in gcc 4.9 or later + OLDCFLAGS="$CFLAGS" + TESTFLAGS="-fstack-protector-strong" + CFLAGS="$CFLAGS $TESTFLAGS" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [ + CFLAGS="$OLDCFLAGS" + TESTFLAGS="-fstack-protector --param=ssp-buffer-size=4" + CFLAGS="$CFLAGS $TESTFLAGS" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [AC_MSG_NOTICE([Not setting $TESTFLAGS]); CFLAGS="$OLDCFLAGS" ] + ) + ] + ) + # FORTIFY_SOURCE + OLDCFLAGS="$CFLAGS" + TESTFLAGS="-D_FORTIFY_SOURCE=2" + CFLAGS="$CFLAGS $TESTFLAGS" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([])], + [AC_MSG_NOTICE([Setting $TESTFLAGS])], + [AC_MSG_NOTICE([Not setting $TESTFLAGS]); CFLAGS="$OLDCFLAGS" ] + ) +fi + # large file support is useful for scp AC_SYS_LARGEFILE @@ -246,7 +305,11 @@ # Checks for header files. AC_HEADER_STDC AC_HEADER_SYS_WAIT -AC_CHECK_HEADERS([fcntl.h limits.h netinet/in.h netinet/tcp.h stdlib.h string.h sys/socket.h sys/time.h termios.h unistd.h crypt.h pty.h ioctl.h libutil.h libgen.h inttypes.h stropts.h utmp.h utmpx.h lastlog.h paths.h util.h netdb.h security/pam_appl.h pam/pam_appl.h netinet/in_systm.h sys/uio.h]) +AC_CHECK_HEADERS([fcntl.h limits.h netinet/in.h netinet/tcp.h stdlib.h \ + string.h sys/socket.h sys/time.h termios.h unistd.h crypt.h \ + pty.h ioctl.h libutil.h libgen.h inttypes.h stropts.h utmp.h \ + utmpx.h lastlog.h paths.h util.h netdb.h security/pam_appl.h \ + pam/pam_appl.h netinet/in_systm.h sys/uio.h linux/pkt_sched.h]) # Checks for typedefs, structures, and compiler characteristics. AC_C_CONST diff -r 4f17d75d027b -r 69862e8cc405 dss.c diff -r 4f17d75d027b -r 69862e8cc405 includes.h --- a/includes.h Fri Jun 23 21:31:49 2017 +0800 +++ b/includes.h Sat Jun 24 00:47:07 2017 +0800 @@ -160,7 +160,7 @@ #define SIZE_T_MAX ULONG_MAX #endif /* SIZE_T_MAX */ -#ifdef SO_PRIORITY +#ifdef HAVE_LINUX_PKT_SCHED_H #include #include #endif diff -r 4f17d75d027b -r 69862e8cc405 netio.c --- a/netio.c Fri Jun 23 21:31:49 2017 +0800 +++ b/netio.c Sat Jun 24 00:47:07 2017 +0800 @@ -307,7 +307,7 @@ #ifdef IPTOS_LOWDELAY int iptos_val = 0; #endif -#ifdef SO_PRIORITY +#ifdef HAVE_LINUX_PKT_SCHED_H int so_prio_val = 0; #endif @@ -340,7 +340,7 @@ } #endif -#ifdef SO_PRIORITY +#ifdef HAVE_LINUX_PKT_SCHED_H if (prio == DROPBEAR_PRIO_LOWDELAY) { so_prio_val = TC_PRIO_INTERACTIVE; } else if (prio == DROPBEAR_PRIO_BULK) { diff -r 4f17d75d027b -r 69862e8cc405 signkey.c diff -r 4f17d75d027b -r 69862e8cc405 svr-authpam.c --- a/svr-authpam.c Fri Jun 23 21:31:49 2017 +0800 +++ b/svr-authpam.c Sat Jun 24 00:47:07 2017 +0800 @@ -224,6 +224,12 @@ goto cleanup; } + if ((rc = pam_set_item(pamHandlep, PAM_RHOST, svr_ses.remotehost)) != PAM_SUCCESS) { + dropbear_log(LOG_WARNING, "pam_set_item() failed, rc=%d, %s", + rc, pam_strerror(pamHandlep, rc)); + goto cleanup; + } + #ifdef HAVE_PAM_FAIL_DELAY /* We have our own random delay code already, disable PAM's */ (void) pam_fail_delay(pamHandlep, 0 /* musec_delay */);