# HG changeset patch # User Matt Johnston # Date 1329919524 -28800 # Node ID a842469ce8ad419b02c09e8da2a52655f273f5fb # Parent 1e0414b29ce9cc00d0cbcaa144efd65df706ef8e - Fix minor leak diff -r 1e0414b29ce9 -r a842469ce8ad svr-authpam.c --- a/svr-authpam.c Wed Feb 22 19:33:07 2012 +0800 +++ b/svr-authpam.c Wed Feb 22 22:05:24 2012 +0800 @@ -56,11 +56,7 @@ struct UserDataS* userDatap = (struct UserDataS*) appdata_ptr; unsigned int msg_len = 0; unsigned int i = 0; - - const char* message = (*msg)->msg; - - /* make a copy we can strip */ - char * compare_message = m_strdup(message); + char * compare_message = NULL; TRACE(("enter pamConvFunc")) @@ -71,15 +67,10 @@ dropbear_log(LOG_INFO, "pamConvFunc() called with >1 messages: not supported."); return PAM_CONV_ERR; } + + /* make a copy we can strip */ + compare_message = m_strdup((*msg)->msg); - TRACE(("msg_style is %d", (*msg)->msg_style)) - if (compare_message) { - TRACE(("message is '%s'", compare_message)) - } else { - TRACE(("null message")) - } - - /* Make the string lowercase. */ msg_len = strlen(compare_message); for (i = 0; i < msg_len; i++) {