# HG changeset patch # User Matt Johnston # Date 1495642180 -28800 # Node ID bc9e2e148f58e7b0bfa0f5c28b141f7263050816 # Parent dd5d7b7141b99b2ed4319fa38657f2434c6d4715 avoid NULL argument to base64 decode diff -r dd5d7b7141b9 -r bc9e2e148f58 signkey.c --- a/signkey.c Tue May 23 22:43:52 2017 +0800 +++ b/signkey.c Thu May 25 00:09:40 2017 +0800 @@ -577,6 +577,10 @@ /* now we have the actual data */ len = line->len - line->pos; + if (len == 0) { + /* base64_decode doesn't like NULL argument */ + return DROPBEAR_FAILURE; + } decodekeylen = len * 2; /* big to be safe */ decodekey = buf_new(decodekeylen);