# HG changeset patch # User Matt Johnston # Date 1519919184 -28800 # Node ID c42e8ff42bd1f7b86c6799f3a6d88cf2a5b907c8 # Parent 119a459b00d0c4adaf432b9818593024e84f4102 Only use malloc wrapper if fuzzing diff -r 119a459b00d0 -r c42e8ff42bd1 dbmalloc.c --- a/dbmalloc.c Thu Mar 01 23:46:07 2018 +0800 +++ b/dbmalloc.c Thu Mar 01 23:46:24 2018 +0800 @@ -1,6 +1,64 @@ #include "dbmalloc.h" #include "dbutil.h" + +void * m_calloc(size_t nmemb, size_t size) { + if (SIZE_T_MAX / nmemb < size) { + dropbear_exit("m_calloc failed"); + } + return m_malloc(nmemb*size); +} + +void * m_strdup(const char * str) { + char* ret; + unsigned int len; + len = strlen(str); + + ret = m_malloc(len+1); + if (ret == NULL) { + dropbear_exit("m_strdup failed"); + } + memcpy(ret, str, len+1); + return ret; +} + +#if !DROPBEAR_TRACKING_MALLOC + +/* Simple wrappers around malloc etc */ +void * m_malloc(size_t size) { + + void* ret; + + if (size == 0) { + dropbear_exit("m_malloc failed"); + } + ret = calloc(1, size); + if (ret == NULL) { + dropbear_exit("m_malloc failed"); + } + return ret; + +} + +void * m_realloc(void* ptr, size_t size) { + + void *ret; + + if (size == 0) { + dropbear_exit("m_realloc failed"); + } + ret = realloc(ptr, size); + if (ret == NULL) { + dropbear_exit("m_realloc failed"); + } + return ret; +} + + +#else + +/* For fuzzing */ + struct dbmalloc_header { unsigned int epoch; struct dbmalloc_header *prev; @@ -90,13 +148,6 @@ return &mem[sizeof(struct dbmalloc_header)]; } -void * m_calloc(size_t nmemb, size_t size) { - if (SIZE_T_MAX / nmemb < size) { - dropbear_exit("m_calloc failed"); - } - return m_malloc(nmemb*size); -} - void * m_realloc(void* ptr, size_t size) { char* mem = NULL; struct dbmalloc_header* header = NULL; @@ -128,17 +179,4 @@ free(header); } -void * m_strdup(const char * str) { - char* ret; - unsigned int len; - len = strlen(str); - - ret = m_malloc(len+1); - if (ret == NULL) { - dropbear_exit("m_strdup failed"); - } - memcpy(ret, str, len+1); - return ret; -} - - +#endif /* DROPBEAR_TRACKING_MALLOC */ diff -r 119a459b00d0 -r c42e8ff42bd1 dbmalloc.h --- a/dbmalloc.h Thu Mar 01 23:46:07 2018 +0800 +++ b/dbmalloc.h Thu Mar 01 23:46:24 2018 +0800 @@ -7,10 +7,19 @@ void * m_calloc(size_t nmemb, size_t size); void * m_strdup(const char * str); void * m_realloc(void* ptr, size_t size); + +#if DROPBEAR_TRACKING_MALLOC void m_free_direct(void* ptr); #define m_free(X) do {m_free_direct(X); (X) = NULL;} while (0) - void m_malloc_set_epoch(unsigned int epoch); void m_malloc_free_epoch(unsigned int epoch, int dofree); +#else +/* plain wrapper */ + +#define m_free(X) do {free(X); (X) = NULL;} while (0) + +#endif + + #endif /* DBMALLOC_H_ */ diff -r 119a459b00d0 -r c42e8ff42bd1 sysoptions.h --- a/sysoptions.h Thu Mar 01 23:46:07 2018 +0800 +++ b/sysoptions.h Thu Mar 01 23:46:24 2018 +0800 @@ -316,4 +316,6 @@ #define DROPBEAR_CLIENT_TCP_FAST_OPEN 0 #endif +#define DROPBEAR_TRACKING_MALLOC (DROPBEAR_FUZZ) + /* no include guard for this file */