# HG changeset patch # User Matt Johnston # Date 1404835997 -28800 # Node ID c88dce72f6d2298c12d43c77616022a32c6e382d # Parent 4ad38e223ccdfe24637ccebd3e11f624c0c021db Make sure client exit messages don't get lost diff -r 4ad38e223ccd -r c88dce72f6d2 cli-main.c --- a/cli-main.c Tue Jul 08 21:59:36 2014 +0800 +++ b/cli-main.c Wed Jul 09 00:13:17 2014 +0800 @@ -107,9 +107,10 @@ /* Do the cleanup first, since then the terminal will be reset */ session_cleanup(); + /* Avoid printing onwards from terminal cruft */ + fprintf(stderr, "\n"); _dropbear_log(LOG_INFO, fmtbuf, param); - exit(exitcode); } @@ -121,7 +122,7 @@ vsnprintf(printbuf, sizeof(printbuf), format, param); fprintf(stderr, "%s: %s\n", cli_opts.progname, printbuf); - + fflush(stderr); } static void exec_proxy_cmd(void *user_data_cmd) { diff -r 4ad38e223ccd -r c88dce72f6d2 common-channel.c --- a/common-channel.c Tue Jul 08 21:59:36 2014 +0800 +++ b/common-channel.c Wed Jul 09 00:13:17 2014 +0800 @@ -574,14 +574,16 @@ } - /* close the FDs in case they haven't been done - * yet (they might have been shutdown etc) */ - TRACE(("CLOSE writefd %d", channel->writefd)) - close(channel->writefd); - TRACE(("CLOSE readfd %d", channel->readfd)) - close(channel->readfd); - TRACE(("CLOSE errfd %d", channel->errfd)) - close(channel->errfd); + if (IS_DROPBEAR_SERVER || (channel->writefd != STDOUT_FILENO)) { + /* close the FDs in case they haven't been done + * yet (they might have been shutdown etc) */ + TRACE(("CLOSE writefd %d", channel->writefd)) + close(channel->writefd); + TRACE(("CLOSE readfd %d", channel->readfd)) + close(channel->readfd); + TRACE(("CLOSE errfd %d", channel->errfd)) + close(channel->errfd); + } if (!channel->close_handler_done && channel->type->closehandler) {