# HG changeset patch # User HansH111 # Date 1647193093 0 # Node ID d39cfedaf0158b05d86c82a7a2673983b3ea3b33 # Parent 4c1560627693b990b0795d85c7041d078cb67c5e extract pubkey_info when seuccesfully auth with a key and free it in the cleanup function diff -r 4c1560627693 -r d39cfedaf015 svr-authpubkey.c --- a/svr-authpubkey.c Sun Mar 13 17:37:44 2022 +0000 +++ b/svr-authpubkey.c Sun Mar 13 17:38:13 2022 +0000 @@ -261,7 +261,7 @@ const char* algo, unsigned int algolen, const unsigned char* keyblob, unsigned int keybloblen) { buffer *options_buf = NULL; - unsigned int pos, len; + unsigned int pos, len, infopos, infolen; int ret = DROPBEAR_FAILURE; if (line->len < MIN_AUTHKEYS_LINE || line->len > MAX_AUTHKEYS_LINE) { @@ -344,6 +344,11 @@ for (len = 0; line->pos < line->len; len++) { if (buf_getbyte(line) == ' ') break; } + /* findout the length of the public key info */ + infopos = line->pos; + for (infolen = 0; line->pos < line->len; infolen++) { + if (buf_getbyte(line) == ' ') break; + } buf_setpos(line, pos); buf_setlen(line, line->pos + len); @@ -351,8 +356,20 @@ ret = cmp_base64_key(keyblob, keybloblen, (const unsigned char *) algo, algolen, line, NULL); - if (ret == DROPBEAR_SUCCESS && options_buf) { - ret = svr_add_pubkey_options(options_buf, line_num, filename); + if (ret == DROPBEAR_SUCCESS) { + if (options_buf) { + ret = svr_add_pubkey_options(options_buf, line_num, filename); + } + /* save the (optional) public key information */ + if (infolen) { + ses.authstate.pubkey_info = m_malloc(infolen + 1); + if (ses.authstate.pubkey_info) { + strncpy(ses.authstate.pubkey_info, &line->data[infopos], infolen); + ses.authstate.pubkey_info[infolen]='\0'; + } + } else { + ses.authstate.pubkey_info = NULL; + } } out: diff -r 4c1560627693 -r d39cfedaf015 svr-authpubkeyoptions.c --- a/svr-authpubkeyoptions.c Sun Mar 13 17:37:44 2022 +0000 +++ b/svr-authpubkeyoptions.c Sun Mar 13 17:38:13 2022 +0000 @@ -115,6 +115,9 @@ } m_free(ses.authstate.pubkey_options); } + if (ses.authstate.pubkey_info) { + m_free(ses.authstate.pubkey_info); + } } /* helper for svr_add_pubkey_options. returns DROPBEAR_SUCCESS if the option is matched,