# HG changeset patch # User Matt Johnston # Date 1125675318 0 # Node ID e923801a7678b84c05ad3c3b793bf52bd58a306b # Parent 961f6a74c5f40642da7f6986e06cff78cfa42825 use a buffer rather than raw char array for creating the comma-seperated algorithm lists diff -r 961f6a74c5f4 -r e923801a7678 common-algo.c --- a/common-algo.c Fri Sep 02 15:33:45 2005 +0000 +++ b/common-algo.c Fri Sep 02 15:35:18 2005 +0000 @@ -209,21 +209,20 @@ /* Output a comma separated list of algorithms to a buffer */ void buf_put_algolist(buffer * buf, algo_type localalgos[]) { - unsigned int pos = 0, i, len; - char str[50]; /* enough for local algo storage */ + unsigned int i, len; + unsigned int donefirst = 0; + buffer *algolist = NULL; + algolist = buf_new(100); for (i = 0; localalgos[i].name != NULL; i++) { if (localalgos[i].usable) { - /* Avoid generating a trailing comma */ - if (pos) - str[pos++] = ','; + if (donefirst) + buf_putbyte(algolist, ','); + donefirst = 1; len = strlen(localalgos[i].name); - memcpy(&str[pos], localalgos[i].name, len); - pos += len; + buf_putbytes(algolist, localalgos[i].name, len); } } - str[pos]=0; - /* Debug this */ - TRACE(("buf_put_algolist: %s", str)) - buf_putstring(buf, str, pos); + buf_putstring(buf, algolist->data, algolist->len); + buf_free(algolist); }