# HG changeset patch # User Matt Johnston # Date 1162486379 0 # Node ID fbcc3b5b34f372a9a9e86db20dfcf661c5f50ea4 # Parent 6aea2cfc113e3787fb1e9a223db9f0681ed71d51 comment about putenv() leaking malloced variables diff -r 6aea2cfc113e -r fbcc3b5b34f3 svr-chansession.c --- a/svr-chansession.c Thu Nov 02 16:45:43 2006 +0000 +++ b/svr-chansession.c Thu Nov 02 16:52:59 2006 +0000 @@ -997,6 +997,7 @@ newvar[plen] = '='; memcpy(&newvar[plen+1], var, vlen); newvar[plen+vlen+1] = '\0'; + /* newvar is leaked here, but that's part of putenv()'s semantics */ if (putenv(newvar) < 0) { dropbear_exit("environ error"); }