Mercurial > dropbear
changeset 1640:228b086794b7
limit password length to 100
| author | Matt Johnston <matt@ucc.asn.au> |
|---|---|
| date | Thu, 21 Mar 2019 00:09:07 +0800 |
| parents | 8a485389330f |
| children | a2bbc22ea1e6 21dabe66f2c8 |
| files | svr-authpasswd.c sysoptions.h |
| diffstat | 2 files changed, 12 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/svr-authpasswd.c Wed Mar 20 23:47:25 2019 +0800 +++ b/svr-authpasswd.c Thu Mar 21 00:09:07 2019 +0800 @@ -65,7 +65,7 @@ } password = buf_getstring(ses.payload, &passwordlen); - if (valid_user) { + if (valid_user && passwordlen <= DROPBEAR_MAX_PASSWORD_LEN) { /* the first bytes of passwdcrypt are the salt */ passwdcrypt = ses.authstate.pw_passwd; testcrypt = crypt(password, passwdcrypt); @@ -80,6 +80,15 @@ return; } + if (passwordlen > DROPBEAR_MAX_PASSWORD_LEN) { + dropbear_log(LOG_WARNING, + "Too-long password attempt for '%s' from %s", + ses.authstate.pw_name, + svr_ses.addrstring); + send_msg_userauth_failure(0, 1); + return; + } + if (testcrypt == NULL) { /* crypt() with an invalid salt like "!!" */ dropbear_log(LOG_WARNING, "User account '%s' is locked",
--- a/sysoptions.h Wed Mar 20 23:47:25 2019 +0800 +++ b/sysoptions.h Thu Mar 21 00:09:07 2019 +0800 @@ -86,6 +86,8 @@ /* Required for pubkey auth */ #define DROPBEAR_SIGNKEY_VERIFY ((DROPBEAR_SVR_PUBKEY_AUTH) || (DROPBEAR_CLIENT)) +#define DROPBEAR_MAX_PASSWORD_LEN 100 + #define SHA1_HASH_SIZE 20 #define MD5_HASH_SIZE 16 #define MAX_HASH_SIZE 64 /* sha512 */