Mercurial > dropbear

changeset 1261:770e14154da3 coverity

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
merge
author Matt Johnston <matt@ucc.asn.au>
date Tue, 15 Mar 2016 23:20:40 +0800
parents 506f7681d0f8 (current diff) c8f52c19e949 (diff)
children 7d02b83c61fd
files
diffstat 4 files changed, 7 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/cli-kex.c	Tue Mar 15 22:45:43 2016 +0800
+++ b/cli-kex.c	Tue Mar 15 23:20:40 2016 +0800
@@ -186,7 +186,7 @@
 
 	char* fp = NULL;
 	FILE *tty = NULL;
-	char response = 'z';
+	int response = 'z';
 
 	fp = sign_key_fingerprint(keyblob, keybloblen);
 	if (cli_opts.always_accept_key) {
--- a/cli-session.c	Tue Mar 15 22:45:43 2016 +0800
+++ b/cli-session.c	Tue Mar 15 23:20:40 2016 +0800
@@ -361,9 +361,10 @@
 
 	/* Set std{in,out,err} back to non-blocking - busybox ash dies nastily if
 	 * we don't revert the flags */
-	fcntl(cli_ses.stdincopy, F_SETFL, cli_ses.stdinflags);
-	fcntl(cli_ses.stdoutcopy, F_SETFL, cli_ses.stdoutflags);
-	fcntl(cli_ses.stderrcopy, F_SETFL, cli_ses.stderrflags);
+	/* Ignore return value since there's nothing we can do */
+	(void)fcntl(cli_ses.stdincopy, F_SETFL, cli_ses.stdinflags);
+	(void)fcntl(cli_ses.stdoutcopy, F_SETFL, cli_ses.stdoutflags);
+	(void)fcntl(cli_ses.stderrcopy, F_SETFL, cli_ses.stderrflags);
 
 	cli_tty_cleanup();
 
--- a/svr-kex.c	Tue Mar 15 22:45:43 2016 +0800
+++ b/svr-kex.c	Tue Mar 15 23:20:40 2016 +0800
@@ -138,7 +138,7 @@
 			break;
 #endif
 		default:
-			(void)0;
+			dropbear_assert(0);
 	}
 
 	if (readhostkey(fn, svr_opts.hostkey, &type) == DROPBEAR_SUCCESS) {
--- a/svr-x11fwd.c	Tue Mar 15 22:45:43 2016 +0800
+++ b/svr-x11fwd.c	Tue Mar 15 23:20:40 2016 +0800
@@ -119,7 +119,7 @@
 	/* cleanup */
 	m_free(chansess->x11authprot);
 	m_free(chansess->x11authcookie);
-	close(fd);
+	m_close(fd);
 
 	return DROPBEAR_FAILURE;
 }