# HG changeset patch
# User Matt Johnston <matt@ucc.asn.au>
# Date 1341328326 -28800
# Node ID f429169aa3cd3a30bac8b294c7866d8a863fad21
# Parent  83c83014e5e3bc0cf50f8af6a53ee0489c0efdab
don't store sensors in eeprom, scan at startup instead

diff -r 83c83014e5e3 -r f429169aa3cd main.c
--- a/main.c	Tue Jul 03 22:44:21 2012 +0800
+++ b/main.c	Tue Jul 03 23:12:06 2012 +0800
@@ -26,7 +26,7 @@
 // 1 second. we have 1024 prescaler, 32768 crystal.
 #define SLEEP_COMPARE 32
 // limited to uint16_t
-#define MEASURE_WAKE 60
+#define MEASURE_WAKE 140
 
 #define VALUE_NOSENSOR 0x07D0 // 125 degrees
 #define VALUE_BROKEN 0x07D1 // 125.0625
@@ -34,7 +34,7 @@
 // limited to uint16_t
 #define COMMS_WAKE 3600 // XXX testing
 // limited to uint8_t
-#define WAKE_SECS 60 // XXX testing
+#define WAKE_SECS 30 // XXX testing
 
 #define BAUD 19200
 #define UBRR ((F_CPU)/8/(BAUD)-1)
@@ -102,6 +102,8 @@
 static char readbuf[30];
 static uint8_t have_cmd;
 
+uint8_t n_sensors;
+uint8_t sensor_id[MAX_SENSORS][ID_LEN];
 
 // thanks to http://projectgus.com/2010/07/eeprom-access-with-arduino/
 #define eeprom_read_to(dst_p, eeprom_field, dst_size) eeprom_read_block((dst_p), (void *)offsetof(struct __eeprom_data, eeprom_field), (dst_size))
@@ -112,9 +114,8 @@
 #define EXPECT_MAGIC 0x67c9
 
 struct __attribute__ ((__packed__)) __eeprom_data {
+    // XXX eeprom unused at present
     uint16_t magic;
-    uint8_t n_sensors;
-    uint8_t sensor_id[MAX_SENSORS][ID_LEN];
 };
 
 #define DEBUG(str) printf_P(PSTR(str))
@@ -259,9 +260,6 @@
 cmd_fetch()
 {
     crc_out = 0;
-    uint8_t n_sensors;
-    eeprom_read(n_sensors, n_sensors);
-
     uint16_t millivolt_vcc = adc_vcc();
 
     uint32_t epoch_copy;
@@ -288,10 +286,8 @@
     fprintf_P(crc_stdout, PSTR("sensors=%u\n"), n_sensors);
     for (uint8_t s = 0; s < n_sensors; s++)
     {
-        uint8_t id[ID_LEN];
         fprintf_P(crc_stdout, PSTR("sensor_id%u="), s);
-        eeprom_read_to(id, sensor_id[s], ID_LEN);
-        printhex(id, ID_LEN, crc_stdout);
+        printhex(sensor_id[s], ID_LEN, crc_stdout);
         fputc('\n', crc_stdout);
     }
     fprintf_P(crc_stdout, PSTR("measurements=%hu\n"), n_measurements);
@@ -328,13 +324,6 @@
 }
 
 static void
-cmd_awake()
-{
-    comms_timeout = WAKE_SECS;
-    printf_P(PSTR("awake %hu\n"), WAKE_SECS);
-}
-
-static void
 cmd_reset()
 {
     printf_P(PSTR("reset\n"));
@@ -417,32 +406,10 @@
 #endif
 
 static void
-add_sensor(uint8_t *id)
-{
-    uint8_t n;
-    eeprom_read(n, n_sensors);
-    if (n < MAX_SENSORS)
-    {
-        cli();
-        eeprom_write_from(id, sensor_id[n], ID_LEN);
-        n++;
-        eeprom_write(n, n_sensors);
-        sei();
-        printf_P(PSTR("Added sensor %d : "), n);
-        printhex(id, ID_LEN, stdout);
-        putchar('\n');
-    }
-    else
-    {
-        printf_P(PSTR("Too many sensors\n"));
-    }
-}
-
-static void
-cmd_add_all()
+init_sensors()
 {
     uint8_t id[OW_ROMCODE_SIZE];
-    printf_P("Adding all\n");
+    printf_P(PSTR("init sensors\n"));
     ow_reset();
     for( uint8_t diff = OW_SEARCH_FIRST; diff != OW_LAST_DEVICE; )
     {
@@ -456,24 +423,26 @@
             printf_P( PSTR("Bus Error\r") );
             return;
         }
-        add_sensor(id);
+
+        if (n_sensors < MAX_SENSORS)
+        {
+            memcpy(sensor_id[n_sensors], id, ID_LEN);
+            printf_P(PSTR("Added sensor %d : "), n_sensors);
+            printhex(id, ID_LEN, stdout);
+            putchar('\n');
+            n_sensors++;
+        }
+        else
+        {
+            printf_P(PSTR("Too many sensors\n"));
+        }
     }
 }
 
 static void
-cmd_init()
-{
-    printf_P(PSTR("Resetting sensor list\n"));
-    uint8_t zero = 0;
-    cli();
-    eeprom_write(zero, n_sensors);
-    sei();
-    printf_P(PSTR("Done.\n"));
-}
-
-static void
 check_first_startup()
 {
+#if 0
     uint16_t magic;
     eeprom_read(magic, magic);
     if (magic != EXPECT_MAGIC)
@@ -488,6 +457,7 @@
         eeprom_write(magic, magic);
         sei();
     }
+#endif
 }
 
 static void
@@ -513,18 +483,6 @@
     {
         cmd_sensors();
     }
-    else if (strcmp_P(readbuf, PSTR("addall"))== 0)
-    {
-        cmd_add_all();
-    }
-    else if (strcmp_P(readbuf, PSTR("awake"))== 0)
-    {
-        cmd_awake();
-    }
-    else if (strcmp_P(readbuf, PSTR("init")) == 0)
-    {
-        cmd_init();
-    }
     else if (strcmp_P(readbuf, PSTR("reset")) == 0)
     {
         cmd_reset();
@@ -659,9 +617,6 @@
 static void
 do_measurement()
 {
-    uint8_t n_sensors;
-    eeprom_read(n_sensors, n_sensors);
-
     blink();
 
     simple_ds18b20_start_meas(NULL);
@@ -683,10 +638,7 @@
         }
         else
         {
-            uint8_t id[ID_LEN];
-            eeprom_read_to(id, sensor_id[s], ID_LEN);
-
-            uint8_t ret = simple_ds18b20_read_raw(id, &reading);
+            uint8_t ret = simple_ds18b20_read_raw(sensor_id[s], &reading);
             if (ret != DS18X20_OK)
             {
                 reading = VALUE_BROKEN;
@@ -733,6 +685,7 @@
         if (have_cmd)
         {
             have_cmd = 0;
+            comms_timeout = WAKE_SECS;
             read_handler();
             continue;
         }
@@ -786,6 +739,8 @@
 
     check_first_startup();
 
+    init_sensors();
+
     uart_off();
 
     // turn off everything except timer2