Mercurial > templog

changeset 629:3e5e52d50af5 rust

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
comment
author Matt Johnston <matt@ucc.asn.au>
date Fri, 19 Apr 2019 13:58:30 +0800
parents e1b5938de122
children 7e9041534891
files rust/src/params.rs
diffstat 1 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/rust/src/params.rs	Fri Apr 19 13:57:40 2019 +0800
+++ b/rust/src/params.rs	Fri Apr 19 13:58:30 2019 +0800
@@ -123,7 +123,9 @@
                 Err(TemplogError::new(&format!("Bad epoch from server '{}' expected '{}'", *le, self.epoch)))
             }
             hyper::StatusCode::NotModified => {
-                // XXX this isn't really an error
+                // XXX this isn't really an error. Should handle_response() return 
+                // Result<Option<Params>, TemplogError> instead?
+
                 Err(TemplogError::new("304 unmodified (long polling timeout at the server)"))
             },
             _ => {